Re: [PATCH] maple: switch to dynamic root device
From: John Paul Adrian Glaubitz
Date: Fri Apr 24 2026 - 16:00:27 EST
Hi Artur,
On Fri, 2026-04-24 at 21:08 +0200, Artur Rojek wrote:
> On 2026-04-24 12:41, Johan Hovold wrote:
> > Driver core expects devices to be dynamically allocated and will, for
> > example, complain loudly when no release function has been provided.
> >
> > Use root_device_register() to allocate and register the root device
> > instead of open coding using a static device.
> >
> > Note that this also fixes a reference leak in case device_register()
> > fails which may be flagged by static checkers.
> >
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
>
> Hi Johan,
>
> thanks for the patch. Verified on real hardware. LGTM:
>
> Acked-by: Artur Rojek <contact@xxxxxxxxxxxxxx>
Maybe add a Tested-by as well.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913