RE: [Intel-wired-lan] [PATCH iwl-net v7 3/3] ice: add dpll peer notification for paired SMA and U.FL pins

[Nowlin, Alexander]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of Petr Oros
> Sent: Friday, April 17, 2026 7:59 AM
> To: netdev@xxxxxxxxxxxxxxx
> Cc: Vecera, Ivan <ivecera@xxxxxxxxxx>; Vadim Fedorenko <vadim.fedorenko@xxxxxxxxx>; Jiri Pirko <jiri@xxxxxxxxxxx>; Rinitha, SX <sx.rinitha@xxxxxxxxx>; Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; 
> Eric Dumazet <edumazet@xxxxxxxxxx>; Kubalewski, Arkadiusz <arkadiusz.kubalewski@xxxxxxxxx>; Loktionov, Aleksandr <aleksandr.loktionov@xxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; Nguyen, 
> Anthony L <anthony.l.nguyen@xxxxxxxxx>; Simon Horman <horms@xxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; Keller, Jacob E <jacob.e.keller@xxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni 
> <pabeni@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [Intel-wired-lan] [PATCH iwl-net v7 3/3] ice: add dpll peer notification for paired SMA and U.FL pins
> 
> SMA and U.FL pins share physical signal paths in pairs (SMA1/U.FL1 and SMA2/U.FL2).  When one pin's state changes via a PCA9575 GPIO write, the paired pin's state also changes, but no notification is sent for > the peer pin.  Userspace consumers monitoring the peer via dpll netlink subscribe never learn about the update.
> 
> Add ice_dpll_sw_pin_notify_peer() which sends a change notification for the paired SW pin.  Call it from ice_dpll_pin_sma_direction_set(), ice_dpll_sma_pin_state_set(), and ice_dpll_ufl_pin_state_set() after
> pf->dplls.lock is released.  Use __dpll_pin_change_ntf() because
> dpll_lock is still held by the dpll netlink layer (dpll_pin_pre_doit).
> 
> Fixes: 2dd5d03c77e2 ("ice: redesign dpll sma/u.fl pins control")
> Signed-off-by: Petr Oros <poros@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/ice/ice_dpll.c | 32 +++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

Tested-by: Alexander Nowlin <alexander.nowlin@xxxxxxxxx>