RE: [PATCH] drm: renesas: rz-du: mipi-dsi: drop duplicate platform_set_drvdata() call
From: John Madieu
Date: Sat Apr 25 2026 - 06:47:18 EST
Hi Biju,
Thank you for your review.
> -----Original Message-----
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Sent: Samstag, 25. April 2026 08:40
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>;
> maarten.lankhorst@xxxxxxxxxxxxxxx; mripard@xxxxxxxxxx;
> tzimmermann@xxxxxxx; airlied@xxxxxxxxx; simona@xxxxxxxx
> Subject: RE: [PATCH] drm: renesas: rz-du: mipi-dsi: drop duplicate
> platform_set_drvdata() call
>
> Hi John,
>
> Thanks for the patch.
>
> > -----Original Message-----
> > From: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> > Sent: 25 April 2026 03:29
> > Subject: [PATCH] drm: renesas: rz-du: mipi-dsi: drop duplicate
> > platform_set_drvdata() call
> >
> > rzg2l_mipi_dsi_probe() calls platform_set_drvdata() twice with the
> > same
> > arguments: once right after devm_drm_bridge_alloc() succeeds and again
> > after the reset controllers have been acquired. The second call is
> redundant; remove it.
> >
> > No functional change.
> >
> > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> > b/drivers/gpu/drm/renesas/rz- du/rzg2l_mipi_dsi.c index
> > 0b4861824319..b8527661a409 100644
> > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> > @@ -1441,8 +1441,6 @@ static int rzg2l_mipi_dsi_probe(struct
> platform_device *pdev)
> > return dev_err_probe(dsi->dev, PTR_ERR(dsi->prstc),
> > "failed to get prst\n");
> >
> > - platform_set_drvdata(pdev, dsi);
> > -
>
> Keep this one here and drop the earlier one as pm_runtime_resume is the
> first user of drvdata.
>
Got it. I'll post a v2 with the appropriate change.
Regards,
John