Re: [PATCH v4 0/4] iio: adc: qcom-pm8xxx-xoadc: add support for reading channel labels from DT
From: Jonathan Cameron
Date: Sun Apr 26 2026 - 09:22:01 EST
On Sat, 25 Apr 2026 20:39:06 +0000 (UTC)
Antony Kurniawan Soemardi <linux@xxxxxxxxxxxxxx> wrote:
> This series adds support for reading channel labels from the device tree
> in the Qualcomm PM8xxx XOADC driver, along with the corresponding DT
> updates for the PM8921 PMIC. Also removes the redundant error logs when
> reading values, as returning -EINVAL and -ETIMEDOUT are sufficient to
> report failures.
>
> This series also includes minor refactors such as remove redundant
> error logging and constifying pointers where applicable.
>
> Tested on Sony Xperia SP (PM8921):
> > cat /sys/bus/iio/devices/iio\:device0/in_voltage7_label
> usb_vbus
> > cat /sys/bus/iio/devices/iio\:device0/in_temp12_label
> ref_muxoff
> > sensors
> iio_hwmon-isa-0000
> Adapter: ISA adapter
> vbat: 267.86 V
> dcin: 4.82 kV
> ...
> chg_temp: +1071.4°C
>
> Note: the sensor readings above are incorrect due to pending calibration
> fixes are not included in this series. This patch only addresses label
> visibility. The values are expected to be wrong until the calibration
> fixes lands separately.
> ---
> Changes in v4:
> - Constify pointers in read operations
Whilst I can't say I care that much about whether we mark everything we
could const, it does no harm.
Applied patches 2-4 to the testing branch of iio.git. I'll rebase that
on rc1 once available and push out as togreg which linux-next will pick up.
Thanks,
Jonathan