Re: [RFC v2 01/10] acpi/x86: s2idle: Rename LPS0 constants so they mirror their function

[Antheas Kapenekakis]

On Sun, 26 Apr 2026 at 16:15, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
>
> On Sat, Apr 25, 2026 at 11:57 PM Antheas Kapenekakis <lkml@xxxxxxxxxxx> wrote:
> >
> > The LPS0 3/4 constants are part of a firmware notification called
> > "Display on/off", in which the device enters a "Screen Off" state.
> > The LPS0 7/8 constants are part of a firmware notification in which
> > a Windows modern standby computer enters a "sleep" state where the
> > CPU may still be active and maintain the radios.
> >
> > However, currently, the values are named as "Screen on/off" and "MS
> > entry/exit", where Modern Standby is abbreviated as "MS". Therefore,
> > perform a minor rename so that the values match their function. Then,
> > fix the debug message to say that it executes notifications instead of
> > entering states as it is otherwise confusing.
> >
> > Signed-off-by: Antheas Kapenekakis <lkml@xxxxxxxxxxx>
> > ---
> >  drivers/acpi/x86/s2idle.c | 84 +++++++++++++++++++++------------------
> >  1 file changed, 45 insertions(+), 39 deletions(-)
> >
> > diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
> > index b6b1dd76a06b..61a044b59776 100644
> > --- a/drivers/acpi/x86/s2idle.c
> > +++ b/drivers/acpi/x86/s2idle.c
> > @@ -43,20 +43,20 @@ static const struct acpi_device_id lps0_device_ids[] = {
> >  #define ACPI_LPS0_DSM_UUID     "c4eb40a0-6cd2-11e2-bcfd-0800200c9a66"
> >
> >  #define ACPI_LPS0_GET_DEVICE_CONSTRAINTS       1
> > -#define ACPI_LPS0_SCREEN_OFF   3
> > -#define ACPI_LPS0_SCREEN_ON    4
> > +#define ACPI_LPS0_DISPLAY_OFF  3
> > +#define ACPI_LPS0_DISPLAY_ON   4
>
> You've clearly ignored my feedback on this.

Hi,

did https://lore.kernel.org/all/CAGwozwE_QbiNk53+kTjwELtWhK31LCrBm5fgx2b46sZa_5wjaA@xxxxxxxxxxxxxx/
not address your feedback?

The notifications are named display off / on in the document you linked.

I did not receive a response so I considered it resolved.

Antheas

> Thanks!
>