Re: [PATCH v2] rust: workqueue: fix SAFETY comment Arc refs in Pin<KBox<T>>
From: Miguel Ojeda
Date: Sun Apr 26 2026 - 13:57:21 EST
On Sun, Apr 26, 2026 at 7:53 PM Sagar Taunk <sagartaunk2@xxxxxxxxx> wrote:
>
> The `WorkItemPointer` implementation for `Pin<KBox<T>>` contained SAFETY
> comments that incorrectly referenced `Arc::into_raw` instead of
> `KBox::into_raw`. This implementation uses `KBox`, not `Arc`, so update
> the comments to accurately reflect the actual ownership transfer.
>
> Fixes: 8373147ce496 ("rust: treewide: switch to our kernel `Box` type")
> Cc: stable@xxxxxxxxxxxxxxx
> Suggested-by: Onur Özkan <contact@xxxxxxxxxxxxx>
> Link: https://github.com/Rust-for-Linux/linux/issues/1233
> Signed-off-by: Sagar Taunk <sagartaunk2@xxxxxxxxx>
I should have mentioned that, in the case of making it a fix, one
usually uses Reported-by: and Closes: instead of Suggested-by: and
Link:
No need for v3 for that I would say -- the maintainers may fix this on apply :)
Thanks!
Cheers,
Miguel