Re: [PATCH v2] ACPI: pmic: Replace mutex_lock/unlock() with guard()/scoped_guard()

[Maxwell Doose]

Hi Andy,

On Fri, Apr 24, 2026 at 5:01 PM Maxwell Doose <m32285159@xxxxxxxxx> wrote:
>
> diff --git a/drivers/acpi/pmic/intel_pmic.c b/drivers/acpi/pmic/intel_pmic.c
> index 134e9ca8eaa2..5c37a8f28e71 100644
> --- a/drivers/acpi/pmic/intel_pmic.c
> +++ b/drivers/acpi/pmic/intel_pmic.c
> @@ -67,14 +67,12 @@ static acpi_status intel_pmic_power_handler(u32 function,
>         if (result == -ENOENT)
>                 return AE_BAD_PARAMETER;
>
> -       mutex_lock(&opregion->lock);
> +       guard(&opregion->lock);
>

I noticed I made a syntax error here, I believe it should be
guard(mutex)(&opregion->lock); instead.

[snip]

> @@ -354,30 +347,28 @@ int intel_soc_pmic_exec_mipi_pmic_seq_element(u16 i2c_address, u32 reg_address,
>
>         d = intel_pmic_opregion->data;
>
> -       mutex_lock(&intel_pmic_opregion->lock);
> +       guard(&intel_pmic_opregion->lock);

Here as well.

I'm going to get this fixed and I'll send you a v3 shortly. In the
meantime, disregard this version.