Re: [PATCH v2 2/2] ntfs: fix WSL symlink target leak on reparse failure

[Hyunchul Lee]

2026년 4월 26일 (일) 오후 1:02, DaeMyung Kang <charsyam@xxxxxxxxx>님이 작성:
>
> ntfs_reparse_set_wsl_symlink() converts the symlink target into an
> allocated NLS string and transfers ownership to ni->target only after
> ntfs_set_ntfs_reparse_data() succeeds. If setting the reparse data fails,
> the converted target is left unreferenced and leaks.
>
> Free the converted target on the reparse update failure path. Use kfree()
> for the other local failure path as well, matching the ntfs_ucstonls()
> allocation contract.
>
> Fixes: fc053f05ca28 ("ntfs: add reparse and ea operations")
> Signed-off-by: DaeMyung Kang <charsyam@xxxxxxxxx>

Looks good to me.

Reviewed-by: Hyunchul Lee <hyc.lee@xxxxxxxxx>

> ---
>  fs/ntfs/reparse.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ntfs/reparse.c b/fs/ntfs/reparse.c
> index 8f60ec6f66c1..74713716813f 100644
> --- a/fs/ntfs/reparse.c
> +++ b/fs/ntfs/reparse.c
> @@ -505,7 +505,6 @@ int ntfs_reparse_set_wsl_symlink(struct ntfs_inode *ni,
>         struct reparse_point *reparse;
>         struct wsl_link_reparse_data *data;
>
> -       utarget = (char *)NULL;
>         len = ntfs_ucstonls(ni->vol, target, target_len, &utarget, 0);
>         if (len <= 0)
>                 return -EINVAL;
> @@ -514,7 +513,7 @@ int ntfs_reparse_set_wsl_symlink(struct ntfs_inode *ni,
>         reparse = kvzalloc(reparse_len, GFP_NOFS);
>         if (!reparse) {
>                 err = -ENOMEM;
> -               kvfree(utarget);
> +               kfree(utarget);
>         } else {
>                 data = (struct wsl_link_reparse_data *)reparse->reparse_data;
>                 reparse->reparse_tag = IO_REPARSE_TAG_LX_SYMLINK;
> @@ -528,6 +527,8 @@ int ntfs_reparse_set_wsl_symlink(struct ntfs_inode *ni,
>                 kvfree(reparse);
>                 if (!err)
>                         ni->target = utarget;
> +               else
> +                       kfree(utarget);
>         }
>         return err;
>  }
> --
> 2.43.0
>


-- 
Thanks,
Hyunchul