Re: [PATCH v3 2/3] staging: sm750fb: Rename init_status members to snake_case

[Greg KH]

On Tue, Apr 07, 2026 at 01:18:04PM +0530, Shubham Chakraborty wrote:
> Rename the init_status structure members powerMode, setAllEngOff, and
> resetMemory to snake_case to follow the kernel coding style.
> 
> Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@xxxxxxxxx>
> ---
>  drivers/staging/sm750fb/sm750.c | 6 +++---
>  drivers/staging/sm750fb/sm750.h | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 729c34372a1e..c30ffab8a5f3 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -921,9 +921,9 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src)
>  	sm750_dev->init_parm.chip_clk = 0;
>  	sm750_dev->init_parm.mem_clk = 0;
>  	sm750_dev->init_parm.master_clk = 0;
> -	sm750_dev->init_parm.powerMode = 0;
> -	sm750_dev->init_parm.setAllEngOff = 0;
> -	sm750_dev->init_parm.resetMemory = 1;
> +	sm750_dev->init_parm.power_mode = 0;
> +	sm750_dev->init_parm.set_all_eng_off = 0;
> +	sm750_dev->init_parm.reset_memory = 1;

If these are only set, and never read, why have them at all?  Why not
just remove them instead?

thanks,

greg k-h