Re: [PATCH v3 3/3] staging: sm750fb: Rename sm750_dev members to snake_case

[Greg KH]

On Tue, Apr 07, 2026 at 01:18:05PM +0530, Shubham Chakraborty wrote:
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index b683a82af349..3f6570fc8f08 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -97,8 +97,8 @@ struct sm750_dev {
>  	unsigned long vidreg_start;
>  	__u32 vidmem_size;
>  	__u32 vidreg_size;
> -	void __iomem *pvReg;
> -	unsigned char __iomem *pvMem;
> +	void __iomem *pv_reg;
> +	unsigned char __iomem *pv_mem;

Why are you keeping the "pv" prefix?  As you know, that's an old-style
notation to try to say this is a pointer to a void, which obviously is
not the kernel coding style.

thanks,

greg k-h