Re: [PATCH] staging: greybus: uart: document c_cflag handling in set_termios
From: Debjeet Banerjee
Date: Mon Apr 27 2026 - 00:16:19 EST
On Sun, 26 Apr 2026 21:16:05 +0200, Greg Kroah-Hartman wrote:
> Ignoring is fine, but shouldn't the bits be cleared to let userspace
> know about this? I think that's why we wrote that FIXME all so long
> ago.
Thanks for the feedback.
That makes sense. I had considered clearing unsupported bits earlier, but held off to
avoid modifying termios and left them ignored instead. Your point about userspace
visibility makes sense.
I'll send a v2 that clears unsupported c_cflag bits accordingly.
Regards,
Debjeet