Re: [PATCH] tty: serial: samsung: add dedicated compatible for exynosauto SoCs

[Krzysztof Kozlowski]

On 26/04/2026 19:18, Alim Akhtar wrote:
> Hi Krzysztof
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>> Sent: Friday, April 24, 2026 9:42 PM
>> To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; gregkh@xxxxxxxxxxxxxxxxxxx;
>> jirislaby@xxxxxxxxxx
>> Cc: linux-serial@xxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux-
>> kernel@xxxxxxxxxxxxxxx
>> Subject: Re: [PATCH] tty: serial: samsung: add dedicated compatible for
>> exynosauto SoCs
>>
>> On 24/04/2026 12:18, Alim Akhtar wrote:
>>> Currently Exynosautov-{9,920} getting probed based on exynos850
>>> fallback. It is recommended to have a dedicated compatible for proper
>>> driver binding.
>>
>> Unfortunately it is not. Dedicated compatible you have. However you are not
>> adding dedicated compatible. You added dedicated driver match entry and
>> we, and especially me, gave reviews many times that it is *not
>> recommended* to have dedicated driver match entry.
>>
> Ok, I might have missed your earlier comments on *not* having a dedicated driver match entry, fair enough.
> 
>> Entire reasoning for doing this patch is wrong. And patch itself is NOOP (at
>> least by quick look).
> Thanks for a quick review, Can you please check the part of the patch which adds OF_EARLYCON_DECLARE
> to add earlycon support?
> 

It also feels unnecessary - existing compatible will be used for
earlycon, no? If matching by existing compatible does not work, commit
msg should explain that.

Best regards,
Krzysztof