Re: [PATCH v4 2/4] iio: adc: qcom-pm8xxx-xoadc: remove redundant error logs when reading values

[Andy Shevchenko]

On Sat, Apr 25, 2026 at 08:39:16PM +0000, Antony Kurniawan Soemardi wrote:
> Drop dev_err() logging for -EINVAL and -ETIMEDOUT cases and rely on
> return values to report errors, reducing unnecessary log noise.

Assuming that this error codes go to the user space without changes,
this LGTM, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

The EINVAL --> ENOENT can be discussed / changed separately later on.

...

> +	if (!wait_for_completion_timeout(&adc->complete,
> +					 VADC_CONV_TIME_MAX_US)) {

I would even dare to make this a single line (82 characters).

-- 
With Best Regards,
Andy Shevchenko