Re: [PATCH v4 12/20] drm/tyr: add parser for firmware binary

[Boris Brezillon]

On Mon, 27 Apr 2026 11:09:25 +0300
Onur Özkan <work@xxxxxxxxxxxxx> wrote:

> > +        let fw_header = Self {
> > +            magic,
> > +            minor,
> > +            major,
> > +            _padding1: padding1,
> > +            version_hash,
> > +            _padding2: padding2,  
> 
> nit: I would write it like this:
> 
> 	_padding1: 0,
> 	version_hash,
> 	_padding2: 0,
> 
> to be more explicit.

OOC, why do we need these padding fields? It looks like we're not doing
doing any raw copy/compare of any sort (fw_header is built using values
read through the cursor). If those are not used/needed, I'd recommend
dropping them.