Re: [PATCH] fs: retire stale lock ordering annotations from inode hash

[Jan Kara]

On Thu 23-04-26 19:04:31, Mateusz Guzik wrote:
> 1. iunique does not take the hash lock as of:
> 3f19b2ab97a97b41 ("vfs, afs, ext4: Make the inode hash table RCU searchable")
> 2. s_inode_list_lock is no longer taken under the hash lock as of:
> c918f15420e336a9 ("fs: call inode_sb_list_add() outside of inode hash lock")
> 
> Signed-off-by: Mateusz Guzik <mjguzik@xxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/inode.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/inode.c b/fs/inode.c
> index 39cb22e63d5b..2ebc3eff64fb 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -53,11 +53,7 @@
>   *   inode->i_lock
>   *
>   * inode_hash_lock
> - *   inode->i_sb->s_inode_list_lock
>   *   inode->i_lock
> - *
> - * iunique_lock
> - *   inode_hash_lock
>   */
>  
>  static unsigned int i_hash_mask __ro_after_init;
> -- 
> 2.48.1
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR