Re: [PATCH] staging: rtl8723bs: rtw_mlme: fix line length warnings

[Luka Gejak]

On April 27, 2026 10:10:17 AM GMT+02:00, Dan Carpenter <error27@xxxxxxxxx> wrote:
>On Sat, Apr 25, 2026 at 02:45:50PM +0200, Luka Gejak wrote:
>> On Fri Apr 24, 2026 at 11:16 PM CEST, Salman Alghamdi wrote:
>> > Fix lines exceeding 100 columns in rtw_mlme.c as flagged by
>> > checkpatch.pl. Wrap long function signatures, function calls,
>> > assignments, and block comments to bring all lines within the
>> > 100 column limit.
>> >
>> > Signed-off-by: Salman Alghamdi <me@xxxxxxxxxxxx>
>> > ---
>> >  drivers/staging/rtl8723bs/core/rtw_mlme.c | 258 +++++++++++++++-------
>> >  1 file changed, 182 insertions(+), 76 deletions(-)
>> >
>> > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
>> > index ddfc56f0253d..fe996484a6ed 100644
>> > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
>> > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
>> > @@ -52,7 +52,10 @@ int	rtw_init_mlme_priv(struct adapter *padapter)
>> >  	pmlmepriv->pscanned = NULL;
>> >  	pmlmepriv->fw_state = WIFI_STATION_STATE; /*  Must sync with rtw_wdev_alloc() */
>> >  	pmlmepriv->cur_network.network.infrastructure_mode = Ndis802_11AutoUnknown;
>> > -	pmlmepriv->scan_mode = SCAN_ACTIVE;/*  1: active, 0: passive. Maybe someday we should rename this varable to "active_mode" (Jeff) */
>> > +	/* 1: active, 0: passive. Maybe someday we should rename this
>> > +	 * variable to "active_mode" (Jeff)
>> > +	 */
>> > +	pmlmepriv->scan_mode = SCAN_ACTIVE;
>> >  
>> >  	spin_lock_init(&pmlmepriv->lock);
>> >  	INIT_LIST_HEAD(&pmlmepriv->free_bss_pool.queue);
>> > @@ -125,7 +128,8 @@ void rtw_free_mlme_priv_ie_data(struct mlme_priv *pmlmepriv)
>> >  	rtw_free_mlme_ie_data(&pmlmepriv->p2p_beacon_ie, &pmlmepriv->p2p_beacon_ie_len);
>> >  	rtw_free_mlme_ie_data(&pmlmepriv->p2p_probe_req_ie, &pmlmepriv->p2p_probe_req_ie_len);
>> >  	rtw_free_mlme_ie_data(&pmlmepriv->p2p_probe_resp_ie, &pmlmepriv->p2p_probe_resp_ie_len);
>> > -	rtw_free_mlme_ie_data(&pmlmepriv->p2p_go_probe_resp_ie, &pmlmepriv->p2p_go_probe_resp_ie_len);
>> > +	rtw_free_mlme_ie_data(&pmlmepriv->p2p_go_probe_resp_ie,
>> > +			      &pmlmepriv->p2p_go_probe_resp_ie_len);
>> >  	rtw_free_mlme_ie_data(&pmlmepriv->p2p_assoc_req_ie, &pmlmepriv->p2p_assoc_req_ie_len);
>> >  }
>> >  
>> > @@ -369,7 +373,8 @@ int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex *dst, u8 fea
>> >  			(d_cap & WLAN_CAPABILITY_ESS));
>> >  }
>> >  
>> > -struct wlan_network *_rtw_find_same_network(struct __queue *scanned_queue, struct wlan_network *network)
>> > +struct wlan_network *_rtw_find_same_network(struct __queue *scanned_queue,
>> > +					    struct wlan_network *network)
>> 					    ^^^^
>> This alignment is wrong please align struct with struct from line above.
>> 
>
>You're looking at it in an email client, you need to look at it
>in the file itself.  (The alignment is fine).
>
>regards,
>dan carpenter
>
>

Hi Dan,
I figured it out. My email client(aerc) is actually showing everything 
correctly, but when I click rq to reply with quotes, my editor(vscode)
shifts everything because of the + and -. Any recommendation?
Best regards,
Luka Gejak