Re: [PATCH] ALSA: hda: cs35l56: Propagate ASP TX source control errors
From: Takashi Iwai
Date: Mon Apr 27 2026 - 07:49:16 EST
On Thu, 23 Apr 2026 15:11:31 +0200,
Cássio Gabriel wrote:
>
> cs35l56_hda_mixer_get() ignores regmap_read() and
> cs35l56_hda_mixer_put() ignores regmap_update_bits_check().
>
> This makes the ASP TX source controls report success when a regmap
> access fails. The write path returns no change instead of an error,
> and the read path continues after a failed read instead of aborting
> the control callback.
>
> Propagate the regmap errors, matching the posture and volume controls
> in this driver.
>
> Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@xxxxxxxxx>
Applied now. Thanks.
Takashi