Re: [PATCH] firmware: google: fix orphaned devices on partial populate failure

[Julius Werner]

Why does device_register() generally fail? Is it usually a problem
with the device specifically (e.g. the device driver probe failed) or
does it always indicate an issue with the core Linux device framework?

The coreboot table entries are generally independent of each other, so
if one of them has a problem that doesn't mean we need to kill all the
others. If there's a chance that later device_register() for other
entries would still succeed, I'd say we should actually just continue
the loop instead of returning immediately. If it is certain that later
entries can also not succeed (e.g. because this error can only happen
when the device framework ran out of some allocatable resource or
something), then I think the current code makes sense that just exits
with the devices we already managed to create.