Re: [PATCH] dt-bindings: regulator: fcs,fan53555: Remove vsel-gpios property

[Alexander Shiyan]

Hello Comor.

> On Mon, Apr 27, 2026 at 02:54:43PM +0300, Alexander Shiyan wrote:
> > The vsel-gpios property is currently documented in the binding but
> > is not used by the driver. The FAN53555 family of regulators supports
> > two voltage selector registers (VSEL0/VSEL1), and the selection between
> > them is intended to be controlled by an external hardware pin (VSEL).
> > However, the driver does not support dynamic toggling of this pin via
> > a GPIO, it only uses the fcs,suspend-voltage-selector property to
> > statically assign which register is used for runtime voltage and which
> > for suspend voltage.
> > Remove the vsel-gpios property from the binding to prevent incorrect DT
> > usage and to reflect the actual hardware description supported by the
> > driver.
>
> From the wording/justification here, I disagree with this patch. The
> binding should document what the hardware can do, not what the driver
> can.
>
> Maybe instead you should make fcs,suspend-voltage-selector mutually
> exclusive with vsel-gpios?

The main problem here is that this feature (vsel-gpios) was never
implemented in the driver. So, the patch consists solely of removing a
non-existent property.

Thanks!