Re: [PATCH] usb: typec: tcpm: replace strcpy with strscpy
From: kernel test robot
Date: Mon Apr 27 2026 - 19:02:34 EST
Hi Maxwell,
kernel test robot noticed the following build errors:
[auto build test ERROR on v7.0]
[cannot apply to usb/usb-testing usb/usb-next usb/usb-linus linus/master next-20260427]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Maxwell-Doose/usb-typec-tcpm-replace-strcpy-with-strscpy/20260427-011111
base: v7.0
patch link: https://lore.kernel.org/r/20260419213638.38291-2-m32285159%40gmail.com
patch subject: [PATCH] usb: typec: tcpm: replace strcpy with strscpy
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260428/202604280624.g6vOa3Cf-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260428/202604280624.g6vOa3Cf-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604280624.g6vOa3Cf-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/usb/typec/tcpm/tcpm.c: In function '_tcpm_log':
>> drivers/usb/typec/tcpm/tcpm.c:729:9: error: expected ';' before '}' token
729 | }
| ^
vim +729 drivers/usb/typec/tcpm/tcpm.c
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 706
e79e01254d02ff drivers/staging/typec/tcpm.c Joe Perches 2017-08-25 707 __printf(2, 0)
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 708 static void _tcpm_log(struct tcpm_port *port, const char *fmt, va_list args)
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 709 {
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 710 char tmpbuffer[LOG_BUFFER_ENTRY_SIZE];
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 711 u64 ts_nsec = local_clock();
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 712 unsigned long rem_nsec;
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 713
d5a4f93511b700 drivers/usb/typec/tcpm.c Peter Chen 2018-06-12 714 mutex_lock(&port->logbuffer_lock);
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 715 if (!port->logbuffer[port->logbuffer_head]) {
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 716 port->logbuffer[port->logbuffer_head] =
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 717 kzalloc(LOG_BUFFER_ENTRY_SIZE, GFP_KERNEL);
d5a4f93511b700 drivers/usb/typec/tcpm.c Peter Chen 2018-06-12 718 if (!port->logbuffer[port->logbuffer_head]) {
d5a4f93511b700 drivers/usb/typec/tcpm.c Peter Chen 2018-06-12 719 mutex_unlock(&port->logbuffer_lock);
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 720 return;
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 721 }
d5a4f93511b700 drivers/usb/typec/tcpm.c Peter Chen 2018-06-12 722 }
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 723
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 724 vsnprintf(tmpbuffer, sizeof(tmpbuffer), fmt, args);
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 725
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 726 if (tcpm_log_full(port)) {
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 727 port->logbuffer_head = max(port->logbuffer_head - 1, 0);
2919950c498311 drivers/usb/typec/tcpm/tcpm.c Maxwell Doose 2026-04-19 728 strscpy(tmpbuffer, "overflow", sizeof(tmpbuffer))
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 @729 }
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 730
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 731 if (port->logbuffer_head < 0 ||
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 732 port->logbuffer_head >= LOG_BUFFER_ENTRIES) {
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 733 dev_warn(port->dev,
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 734 "Bad log buffer index %d\n", port->logbuffer_head);
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 735 goto abort;
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 736 }
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 737
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 738 if (!port->logbuffer[port->logbuffer_head]) {
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 739 dev_warn(port->dev,
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 740 "Log buffer index %d is NULL\n", port->logbuffer_head);
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 741 goto abort;
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 742 }
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 743
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 744 rem_nsec = do_div(ts_nsec, 1000000000);
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 745 scnprintf(port->logbuffer[port->logbuffer_head],
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 746 LOG_BUFFER_ENTRY_SIZE, "[%5lu.%06lu] %s",
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 747 (unsigned long)ts_nsec, rem_nsec / 1000,
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 748 tmpbuffer);
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 749 port->logbuffer_head = (port->logbuffer_head + 1) % LOG_BUFFER_ENTRIES;
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 750
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 751 abort:
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 752 mutex_unlock(&port->logbuffer_lock);
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 753 }
f0690a25a140b8 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 754
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki