Re: [PATCH] media: atomisp: Remove unnecessary function return

[Helen Koike]

Hi Everton,

Thanks for your patch, please see my comments below.

On 4/24/26 5:55 AM, Andy Shevchenko wrote:
> On Thu, Apr 23, 2026 at 03:38:14PM -0300, Everton Colombo wrote:
>
> > ---
> > Hey, this is my first patch! Any feedback would be appreciated!
>
> Please, start reviewing others' patches for the same driver and read other
> reviews and learn from them first.

fyi, you can check previous reviews on this driver on lore.kernel.org, 
for instance: https://lore.kernel.org/all/?q=atomisp

> I'm not going to repeat what I said already several times on a patches like
> this over the very same driver (atomisp).

You can see in the previous reviews a few comments to not fix just a 
single occurrence of the issue on the driver, but to fix in a set of 
files or in the entire driver.

This same error occurs multiple times on the same file, and also in the 
entire driver.

My suggestion is for you to fix all this sort of errors under the folder
   drivers/staging/media/atomisp/pci/hive_isp_css_common/host/
otherwise it might become a big commit for a first contribution (unless 
others think otherwise).

i.e.:

   ./scripts/checkpatch.pl 
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/* | \
   grep -a3 "WARNING: void function return statements are not generally 
useful"

I hope this helps.

Regards,
Helen