Re: [PATCH v2] ALSA: usb-audio: Add quirk for PreSonus AudioBox USB

[Takashi Iwai]

On Tue, 28 Apr 2026 02:51:19 +0200,
Abhinav Mahadevan wrote:
> 
> The PreSonus AudioBox USB (0x194f:0x0301) only supports S24_3LE
> format for both playback and capture. It does not support S16_LE
> despite being a USB full-speed device. Add explicit format quirks
> for both the playback (interface 2) and capture (interface 3)
> interfaces to ensure correct format negotiation.
> 
> Signed-off-by: Abhinav Mahadevan <abhi220204@xxxxxxxxx>
> ---
> 
> v2: Fix placement -  entry was incorrectly inside a #if 0 disabled block.
> Moved to after the #endif /* disabled */.

The patch description doesn't match with what you actually change
here.  Also, as it's a correction, it should have a Fixes tag.
Please update the description and resubmit.


thanks,

Takashi

>  
>  sound/usb/quirks-table.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> index 803e03d4d..4e9cfff40 100644
> --- a/sound/usb/quirks-table.h
> +++ b/sound/usb/quirks-table.h
> @@ -2652,6 +2652,9 @@ YAMAHA_DEVICE(0x7010, "UB99"),
>  		}
>  	}
>  },
> +
> +#endif /* disabled */
> +
>  {
>  	/*
>  	 * The AudioBox USB advertises S24_3LE as the only supported format
> @@ -2700,7 +2703,6 @@ YAMAHA_DEVICE(0x7010, "UB99"),
>  		}
>  	}
>  },
> -#endif /* disabled */
>  
>  {
>  	/*
> -- 
> 2.43.0
>