Re: [PATCH] serial: 8250_pci: skip WCH PCI serial devices

From: Andy Shevchenko

Date: Tue Apr 28 2026 - 06:00:44 EST


On Tue, Apr 28, 2026 at 04:26:34PM +0800, Jiawei liu wrote:
> WCH PCI serial devices implement vendor-specific extensions
> beyond the standard 16C550 UART. These are not supported by
> the generic 8250 PCI driver, and binding them may lead to
> incorrect or suboptimal operation.
>
> Skip these devices during probe to avoid misbinding.
>
> Signed-off-by: Jiawei Liu <liujiawei4419@xxxxxxxxx>

Besides the broken way on sending patches — spend your time reading
documentation and reviewing others' code first, please, — this change
breaks the cases where it works.

100% NAK. Try again when you will have a driver that supports them including
mentioned vendor extensions, before that this patch won't ever be accepted.


--
With Best Regards,
Andy Shevchenko