Re: [PATCH] firmware: samsung: fix stale response flag in acpm_prepare_xfer()

[Krzysztof Kozlowski]

On 27/04/2026 23:37, Titouan Ameline wrote:
> I was reading through the driver code and noticed that
> acpm_prepare_xfer() only enters the
> 
> if (xfer->rxd) branch to set response = true
> with no corresponding else to reset it to false.
> 
> Since seqnum slots are recycled, I traced what happens when a slot
> previously used by a response-expecting transfer gets reused by a
> fire-and-forget one
> 
> -> the stale true remains and the wrong branch is taken in acpm_get_rx().
> 
> Le lun. 27 avr. 2026 à 10:48, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> a écrit :
>>

This seams to duplicate Tudor's earlier patches and his solution looks
more complete, so I will take his work with Reported-by credits.

Best regards,
Krzysztof