Re: [PATCH 17/48] objtool: Fix reloc hash collision in find_reloc_by_dest_range()

From: Miroslav Benes

Date: Tue Apr 28 2026 - 08:58:31 EST


On Wed, 22 Apr 2026 21:03:45 -0700, Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> In find_reloc_by_dest_range(), hash collisions can cause a high-offset
> relocation to appear when probing a low-offset hash bucket.
>
> Only return early when the best match found so far genuinely belongs to
> the current bucket (its offset is within the bucket's stride range).
> Otherwise, continue scanning later buckets which may contain
> lower-offset matches.
>
> [...]

Reviewed-by: Miroslav Benes <mbenes@xxxxxxx>

--
Miroslav