Re: [Intel-wired-lan] [PATCH v2] ice: wait for reset completion in ice_resume()

[Przemek Kitszel]

> > > > +     ret = ice_wait_for_reset(pf, 10 * HZ);
> > >
> > > Why not pass a delay in micro/milliseconds?
> >
> > ice_wait_for_reset() takes jiffies — that's the existing API.
>
> It’s recommended to use `msecs_to_jiffies()` to make it HZ invariant.

there is also secs_to_jiffies()

> > > > +     if (ret)
> > > > +             dev_err(dev, "Wait for reset failed during resume: 
> > > > %d\n", ret);
> > >
> > > Mention the delay?
> >
> > Good point. I'll include the timeout in the error message in v3.
>
> Awesome.
>
> […]
>
>
> Thanks,
>
> Paul