Re: [PATCH v4 2/2] scripts: generate_rust_analyzer.py: fix IDE support for primitive types

[Jesung Yang]

On Sun, Apr 26, 2026 at 12:43 PM Jesung Yang <y.j3ms.n@xxxxxxxxx> wrote:
>
> The conditional guard actually lives in the first patch:
>
> +        crate_attrs = (
> +            crate_attrs if ctx.use_crate_attrs and crate_attrs is not
> None else []
> +        )
>
> ... and I don't understand why I bundled this into the first patch.
>
> Apologies for the confusion, I'll move the logic related to
> `use_crate_attrs` to this patch (i.e., [PATCH v4 2/2] scripts:
> generate_rust_analyzer.py: fix IDE support for primitive types).

I think it'd be more natural to locate the conditional logic based on
`RaVersionCtx.manual_sysroot_crates` and `RaVersionCtx.use_crate_attrs`
in the same patch, since both need to be grouped together to properly
fix IDE support for primitive types.

I'll move the introduction of the entire `RaVersionCtx` to the second
patch.

Best regards,
Jesung