Re: [PATCH v2] drm/xe: Don't use UTS_RELEASE directly

[Uwe Kleine-König (The Capable Hub)]

On Tue, Apr 28, 2026 at 02:09:31PM +0300, Jani Nikula wrote:
> On Tue, 28 Apr 2026, Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx> wrote:
> > UTS_RELEASE evaluates to a static string and changes quite easily (e.g.
> > uncommitted changes in the source tree or new commits). So when checking
> > if a patch introduces changes to the resulting binary each usage of
> > UTS_RELEASE is source of annoyance.
> >
> > Instead of using UTS_RELEASE directly use init_utsname()->release which
> > evaluates to the same string but with that a change of UTS_RELEASE
> > doesn't affect xe_devcoredump.o.
> >
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
> 
> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>

Thanks!

> > (implicit) v1 of this patch is available at 
> > https://lore.kernel.org/20260427160902.1126027-2-u.kleine-koenig%40baylibre.com.
> >
> > The only changes since then is that instead of dropping the kernel line,
> > init_utsname()->release is used, which is nearly what Jani Nikula
> > suggested.
> 
> Almost the same, but better. ;)
> 
> I wonder if most UTS_RELEASE uses in the kernel should be changed the
> same way?

I have adapting these on my todo list.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature