Re: [PATCH] workqueue: fix devm_alloc_workqueue() va_list misuse

From: Breno Leitao

Date: Tue Apr 28 2026 - 11:01:17 EST


On Mon, Apr 27, 2026 at 07:29:31AM -1000, Tejun Heo wrote:
> Nice catch. Could you fold both noprof entries onto a shared helper?
>
> static struct workqueue_struct *
> alloc_workqueue_va(const char *fmt, unsigned int flags,
> int max_active, va_list args)
> {
> struct workqueue_struct *wq;
>
> wq = __alloc_workqueue(fmt, flags, max_active, args);
> if (wq)
> wq_init_lockdep(wq);
> return wq;
> }
>
> alloc_workqueue_lockdep_map() can stay on bare __alloc_workqueue() since
> it supplies its own lockdep_map.

Ack, I will update and respin.

Thanks for the review,
--breno