Re: [PATCH v2 4/5] iio: light: si1133: group generic <linux/*> headers
From: Jonathan Cameron
Date: Tue Apr 28 2026 - 11:27:45 EST
On Tue, 28 Apr 2026 15:18:36 +0200
Joshua Crofts via B4 Relay <devnull+joshua.crofts1.gmail.com@xxxxxxxxxx> wrote:
> From: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
>
> Group generic <linux/*> include headers to improve code style.
Not particularly important but you could mention why these two are
where they are. For the unaligned one that was a mass replacement
of asm/unaligned with linux/unaligned that didn't reflect local
ordering. No idea for util_macros.h!
>
> No functional change.
>
> Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> ---
> drivers/iio/light/si1133.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c
> index 5c5c5ae0535a9592522c0b21496f47068044c6ff..f2a79675c026c86bb56d85a65cd035d7540d0ef8 100644
> --- a/drivers/iio/light/si1133.c
> +++ b/drivers/iio/light/si1133.c
> @@ -21,14 +21,12 @@
> #include <linux/mutex.h>
> #include <linux/regmap.h>
> #include <linux/types.h>
> +#include <linux/unaligned.h>
> +#include <linux/util_macros.h>
>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
>
> -#include <linux/util_macros.h>
> -
> -#include <linux/unaligned.h>
> -
> #define SI1133_REG_PART_ID 0x00
> #define SI1133_REG_REV_ID 0x01
> #define SI1133_REG_MFR_ID 0x02
>