Re: [PATCH v0 00/14] iio: magnetometer: ak8975: Additional changes to the driver

From: Jonathan Cameron

Date: Tue Apr 28 2026 - 12:34:18 EST


On Tue, 28 Apr 2026 09:14:55 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:

> On Tue, 28 Apr 2026 at 09:03, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Apr 28, 2026 at 08:37:22AM +0200, Joshua Crofts wrote:
> > > On Mon, 27 Apr 2026 at 22:14, Andy Shevchenko
> > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > >
> > > > This series is an attempt to make the driver less a rabbit hole.
> > > > It's a continuation of what Joshua Crofts started doing. Hence
> > > > it is based on his work and first three "patches" here are supposed
> > > > to be folded to his series accordingly.
> > > >
> > > > I have compile-tested them, but I haven't done full double check of
> > > > the correctness from functional point of view. Joshua, please do that
> > > > before incorporating into your series. Yes, my patches are assumed to
> > > > become the part of Joshua's whatever next version of the series, that's
> > > > why mine is marked as v0.
> > > >
> > > > Should not be taken directly by the maintainers, but any comments, review
> > > > are highly appreciated.
> > >
> > > When you said a few changes, I didn't expect an 11-part series :). I'll go over
> > > them and am them to my branch. I might check out the guard()() and chip_info
> > > changes.
> >
> > On top of that also one may consider to switching to use reset-gpio instead of
> > poking "reset" GPIO directly. But this sounds like too many for one go, let's
> > make this 17 patch series go (6 yours + 11 mine).
>
> Fair enough, perhaps another time.
>
> BTW, if I'm sending your patches to the list, I should also add a Signed-off-by
> tag to the end, right?
>
Yes. You are 'handling' the patches, so need to add your sign off.