Re: [PATCH] mm/huge_memory: Fix outdated comment about freeing subpages in __folio_split

[Barry Song]

On Tue, Apr 28, 2026 at 9:01 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, 28 Apr 2026 18:32:40 +0800 Barry Song <baohua@xxxxxxxxxx> wrote:
>
> > On Tue, Apr 28, 2026 at 6:08 PM David Hildenbrand (Arm)
> > <david@xxxxxxxxxx> wrote:
> > >
> > > On 4/28/26 12:05, Barry Song wrote:
> > > > On Mon, Apr 27, 2026 at 3:42 PM David Hildenbrand (Arm)
> > > > <david@xxxxxxxxxx> wrote:
> > > >>
> > > >> On 4/26/26 22:42, Barry Song wrote:
> > > >>> On Thu, Apr 23, 2026 at 8:36 PM David Hildenbrand (Arm)
> > > >>> <david@xxxxxxxxxx> wrote:
> > > >>>
> > > >>> Thanks, david! would it make more sense to add “when
> > > >>> CONFIG_PAGE_MAPCOUNT is enabled” at the end of the
> > > >>> sentence?
> > > >>
> > > >> Better to phrase it in a way that doesn't even require these details :)
> > > >>
> > > >> Do we even need this detail in the patch description?
> > > >
> > > > What about:
> > > >
> > > > The comment appears to be outdated. add_to_swap() no longer exists,
> > > > and the explanation of why we need to call put_page() after
> > > > splitting could be made more general.
> > >
> > > Jup :)
> >
> > Thanks!
> > Hi Andrew, would you like to make the change in the
> > changelog, or would you prefer that I send a new version?
>
> This?

Yes, exactly.

Thanks very much!

>
> From: "Barry Song (Xiaomi)" <baohua@xxxxxxxxxx>
> Subject: mm/huge_memory: fix outdated comment about freeing subpages in __folio_split
> Date: Thu, 23 Apr 2026 11:49:17 +0800
>
> The comment appears to be outdated.  add_to_swap() no longer exists,
> and the explanation of why we need to call put_page() after splitting
> could be made more general.