Re: [PATCH v2] mm/gup: cleanup pgtable entry accessors

[David Hildenbrand (Arm)]

On 4/29/26 07:17, Alexander Gordeev wrote:
> On Tue, Apr 28, 2026 at 09:45:59PM +0200, David Hildenbrand (Arm) wrote:
>> In general, LGTM.
>>
>> I do wonder, though, if we want to switch to pte_same/pmd_same/pud_same while at it?
> 
> I thought about that too, but decided to keep it focused on direct
> dereferences (as it fixes a real issue with the pte kasan sanitizer).
> 
> I can send updated patch or a follow-up patch - as you prefer. But
> if you like the follow-up I would suggest to un-squash the original
> series to get it in three logical steps: 1 - pXdp_get() fix, 2 -
> lockless access fix, 3 - pXd_same() cleanup.

I'd prefer to keep 1 and 2 squashed. I don't see a good reason to temporarily do
the wrong thing :)

A follow-up patch works for me, thanks!

Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

-- 
Cheers,

David