Re: [PATCH] drm/msm: Don't use UTS_RELEASE directly
From: Andy Shevchenko
Date: Wed Apr 29 2026 - 02:14:51 EST
On Tue, Apr 28, 2026 at 06:39:53PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> On Tue, Apr 28, 2026 at 06:56:15PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 28, 2026 at 04:45:53PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > > UTS_RELEASE evaluates to a static string and changes quite easily (e.g.
> > > uncommitted changes in the source tree or new commits). So when checking
> > > if a patch introduces changes to the resulting binary each usage of
> > > UTS_RELEASE is source of annoyance.
> > >
> > > Instead of using UTS_RELEASE directly use init_utsname()->release which
> > > evaluates to the same string but with that a change of UTS_RELEASE
> > > doesn't affect msm_disp_snapshot_util.o or msm_gpu.o.
> >
> > Would you like to submit similar changes against driver/auxdisplay?
>
> These didn't pollute my build results so far, so my pressure is small.
> (Two of the three are not relevant for an allmodconfig build and the
> third depends on PLAT_VERSATILE which isn't in my build matrix.)
>
> I assume you ask because if I say no you'd address that? In that case
> please go on.
Okay, noted.
Thanks for bringing in the way how to solve it!
--
With Best Regards,
Andy Shevchenko