Re: [PATCH 4/5] arm64: dts: qcom: add IPQ9650 SoC and rdp488 board support

[Konrad Dybcio]

On 4/29/26 5:58 AM, Kathiravan Thirumoorthy wrote:
> 
> On 4/24/2026 4:51 PM, Konrad Dybcio wrote:
>> On 4/15/26 3:33 PM, Kathiravan Thirumoorthy wrote:
>>> Add initial device tree support for the Qualcomm IPQ9650 SoC and
>>> rdp488 board.
>>>
>>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@xxxxxxxxxxxxxxxx>
>>> ---
>> Overall looks good, just a couple comments
>>
>> [...]
>>
>>> +        CPU0: cpu@0 {
>> Labels should be lowercase
> 
> Ack.
> 
>>
>>> +            device_type = "cpu";
>>> +            compatible = "arm,cortex-a55";
>>> +            reg = <0x0>;
>>> +            enable-method = "psci";
>>> +            next-level-cache = <&l2_0>;
>> You likely want to add #cooling-cells = <2>
> 
> I left it because to add it along with the TSENS support. Do you prefer to add it now? do let me know.

Up to you, it's not very useful without tsens

Konrad