Re: [RESEND PATCH] s390: fix dead defaults for S390_MODULES_SANITY_TEST and S390_UNWIND_SELFTEST

[Alexander Gordeev]

On Tue, Apr 14, 2026 at 10:56:51PM +0100, Julian Braha wrote:
> These config options currently have unconditional defaults of 'n' from the
> def_tristate statement, which shadow the later default of
> 'KUNIT_ALL_TESTS', causing it to be dead code.
> 
> It looks to me like the commit 25d36a85c61b ("s390/test_unwind: convert to KUnit")
> added the KUNIT_ALL_TESTS default to S390_UNWIND_SELFTEST, but mistakenly
> didn't remove the previous 'n' default.
> 
> Then, the later commit 90c5318795ee ("s390/module: test loading modules with a lot of relocations")
> copied the Kconfig layout from S390_UNWIND_SELFTEST when adding the
> S390_MODULES_SANITY_TEST config option, without noticing the existing mistake.
> 
> This dead code was found by kconfirm, a static analysis tool for Kconfig.

This tool is still in development, right?

Anyway, I do not quite get what do you mean with the dead code.
Could you please elaborate?

> Fixes: 25d36a85c61b ("s390/test_unwind: convert to KUnit")
> Fixes: 90c5318795ee ("s390/module: test loading modules with a lot of relocations")
> Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx>
> ---
>  arch/s390/Kconfig | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Thanks!