Re: [PATCH RESEND net-next] net/sun: Fix multiple typos in comments

[Jakub Kicinski]

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
---
net/sun: Fix multiple typos in comments

This patch fixes various typos in comments across the sun ethernet
drivers. A couple of the replacements may warrant a second look.

> diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c
> index fe00e7dd3fe4..74fb0de12d21 100644
> --- a/drivers/net/ethernet/sun/cassini.c
> +++ b/drivers/net/ethernet/sun/cassini.c

[ ... ]

> @@ -4547,7 +4547,7 @@ static int cas_get_link_ksettings(struct net_device *dev,
>  	}
>  	if (linkstate != link_up) {
>  		/* Force these to "unknown" if the link is not up and
> -		 * autonogotiation in enabled. We can set the link
> +		 * autonegotiation in enabled. We can set the link

The "autonogotiation" to "autonegotiation" change looks correct, but
the neighbouring "in enabled" in the same sentence appears to be a
leftover grammar slip (should it read "is enabled"?).  Since this
sentence is already being touched as part of the typo cleanup, would
it make sense to fix that at the same time?

>  		 * speed to 0, but not cmd->duplex,
>  		 * because its legal values are 0 and 1.  Ethtool will
>  		 * print the value reported in parentheses after the

[ ... ]

> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
> index 4c9d5d4dd8a0..efbf042e9352 100644
> --- a/drivers/net/ethernet/sun/sunhme.c
> +++ b/drivers/net/ethernet/sun/sunhme.c
> @@ -1118,7 +1118,7 @@ static void happy_meal_transceiver_check(struct happy_meal *hp, void __iomem *tr
>   *
>   * We use skb_reserve() to align the data block we get in the skb.  We
>   * also program the etxregs->cfg register to use an offset of 2.  This
> - * imperical constant plus the ethernet header size will always leave
> + * emperical constant plus the ethernet header size will always leave

Neither "imperical" nor "emperical" is a correct English word; the
intended word is "empirical".  Was the replacement here meant to be
"empirical"?

>   * us with a nicely aligned ip header once we pass things up to the
>   * protocol layers.
>   *
-- 
pw-bot: cr