Re: [PATCH] psp: reject packets carrying unsupported PSP optional fields
From: David CARLIER
Date: Thu Apr 30 2026 - 07:00:16 EST
Hi
> [...] we should fix it by validating that it is less than the
> remaining bytes after the psp-udp header, and then stripping the
> correct header length accordingly.
Makes sense, I'll respin to compute the strip length from
psph->hdrlen (after a second pskb_may_pull to bring the option
bytes in) and drop the rejection -- easier to ignore VC/options
than to refuse them.
> For the other two, I'm not sure they are really necessary.
Will drop both, agreed.
> [...] this function will also need a comment update [...]
Will refresh the kerneldoc.
> For a fix, you'll need to target the net tree with this patch
Ack, will rebase on net for v2.
Thanks,