RE: [PATCH 0/3] EDAC: fix error reporting handling during init for
From: Zhuo, Qiuxu
Date: Thu Apr 30 2026 - 10:19:08 EST
Hi Tushar,
> From: Tushar Tibude <tushar.tibude1000@xxxxxxxxx>
> Sent: Thursday, April 30, 2026 4:42 PM
> To: mchehab@xxxxxxxxxx; bp@xxxxxxxxx; Luck, Tony <tony.luck@xxxxxxxxx>;
> linux-edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Zhuo, Qiuxu <qiuxu.zhuo@xxxxxxxxx>; Tushar Tibude
> <tushar.tibude1000@xxxxxxxxx>
> Subject: [PATCH 0/3] EDAC: fix error reporting handling during init for
>
> For some drivers, during initialization error reporting is enabled, but not
> properly handled during teardown or init fail, and this leaves it enabled in the
> register on exit.
>
> This inconsistency was first identified for i7300_edac.c and a patch addressing
> it was reviewed:
>
> Link: https://lore.kernel.org/linux-edac/20260429094806.25097-1-
> tushar.tibude1000@xxxxxxxxx/
>
> It was then discovered across multiple i5xxx drivers:
>
> i5000_edac.c
> i5100_edac.c
> i5400_edac.c
>
> This patch series aims to implement a fix for each of them.
Thanks for the patch.
Since this addresses the same issue with the same simple fix in the same subsystem,
IMHO it's better to combine this series and the missing fix for driver [1] with your
previous fix [2] into a single patch, rather than having 5 separate patches.
But please wait for comments from @Luck, Tony and @Borislav Petkov (AMD) on whether
to use a single patch or multiple patches.
[1] https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/edac/i7300_edac.c#n1092
[2] https://lore.kernel.org/all/20260429094806.25097-1-tushar.tibude1000@xxxxxxxxx/
Thanks!
-Qiuxu