Re: [PATCH net-next 3/4] r8152: Add irq mitigation for RTL8157/9

[Andrew Lunn]

> Also, I only see the issue on slow 5GBit USB-C connections, sometimes with
> the RTL8157, basically every time with the RTL8159, and so far never on a
> 20GBit USB-C connection, so the mitigation is probably some kind of
> interrupt coalescing.

Do you notice any latency changes with this setting in place? Or CPU load.

ping can be a good measure for latency.

If this is interrupt coalescing, it normally means don't interrupt as
soon as one packet has been received. Delay the interrupt, so there
are likely to be more packets in the receive queue. The cost of the
interrupt handling is then spread over a number of packets.

If this register setting is disabling coalescing, you should see the
latency go down, but the CPU load go up.

If you are getting interrupts after the device has been disabled, i
guess it is because the timer for a delayed interrupt is not cancelled
by the firmware. If so you might be able to work around this firmware
bug. Disable the receiver, sleep for 10ms but keep processing
interrupts, and then continue with the tear down.

	Andrew