Re: [PATCH] riscv: dts: thead: Enable WiFi on Lichee Pi 4A

[Drew Fustini]

On Sun, Apr 26, 2026 at 01:52:29PM +0800, MoeLeak wrote:
> Signed-off-by: MoeLeak <i@xxxxxxxx>

There needs to be proper commit message with a description of why the
change is being made. Please run scripts/checkpatch.pl before
resending as this would have called out the missing commit message.

Also please review Documentation/process/submitting-patches.rst or visit
https://docs.kernel.org/process/submitting-patches.html

Please include revision number in the patch Subject: and also after the
'---' line in the patch so it is easier for a reviewer to know what
changed.

In addition, the To: and Cc: fields are missing several addresses per
MAINTAINERS. Please run scripts/get_maintainer.pl and make sure to
include the recommended addresses. For example:

./scripts/get_maintainer.pl -norolestats --separator="," <patch>

However, I have been using the wonderful b4 script for awhile now and it
makes the above much easier:

https://b4.docs.kernel.org/en/latest/contributor/overview.html

My flow would be something like:

b4 prep -n your-patch-topic # create new branch for your patch
b4 prep --edit-cover # creates the cover letter
b4 prep --auto-to-cc # this adds all the necessary people and lists
b4 prep --check # this runs checkpatch
b4 send --reflect # emails just yourself to review before sending
b4 send # actually posts your patch to the lists

You don't have to use it for this patch but keep it in mind as it can
prevent mistakes and save a lot time.

> ---
>  .../boot/dts/thead/th1520-lichee-pi-4a.dts    | 47 +++++++++++++++++++
>  arch/riscv/boot/dts/thead/th1520.dtsi         | 11 +++++
>  2 files changed, 58 insertions(+)

I think these should be split into two separate patches. The first
patch would add the i2c node in th1520.dtsi and the second patch would
make the changes to th1520-lichee-pi-4a.dts.

Thanks,
Drew