Re: [PATCH] hwmon: Remove stale CONFIG_SENSORS_SBRMI Makefile reference

[Guenter Roeck]

On Sat, Apr 25, 2026 at 08:03:19PM -0400, Sasha Levin wrote:
> kconfiglint reports:
> 
>   X001: CONFIG_SENSORS_SBRMI referenced in Makefile but not defined
>         in any Kconfig
> 
> The SB-RMI hardware monitoring driver was originally introduced in
> commit 5a0f50d110b3 ("hwmon: Add support for SB-RMI power module") with
> both a Kconfig entry (CONFIG_SENSORS_SBRMI) and a Makefile line
> (obj-$(CONFIG_SENSORS_SBRMI) += sbrmi.o) in drivers/hwmon/.
> 
> Commit e156586764050 ("hwmon/misc: amd-sbi: Move core sbrmi from hwmon to
> misc")
> moved the driver to drivers/misc/amd-sbi/ to support additional
> functionality beyond hardware monitoring. That commit correctly removed the
> Kconfig entry from drivers/hwmon/Kconfig, moved the source file
> drivers/hwmon/sbrmi.c to drivers/misc/amd-sbi/sbrmi.c, and created new
> Kconfig/Makefile entries in drivers/misc/amd-sbi/ with a renamed symbol
> (CONFIG_AMD_SBRMI_I2C).
> 
> However, the Makefile line in drivers/hwmon/Makefile was not removed in
> that commit. The orphaned line references a CONFIG symbol that no longer
> exists and a source file that is no longer present, so it has no effect
> on the build — but it is dead code that should be cleaned up.
> 
> Remove the stale Makefile reference.
> 
> Assisted-by: Claude:claude-opus-4-6 kconfiglint
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

Applied.

Thanks,
Guenter