Re: [PATCH v2] bitops: use correct parameter names in kernel-doc

From: Randy Dunlap

Date: Fri May 01 2026 - 01:02:25 EST




On 4/30/26 5:11 PM, Yury Norov wrote:
> On Thu, Apr 30, 2026 at 04:39:34PM -0700, Randy Dunlap wrote:
>> Fix the kernel-doc comments to use the correct parameter names to
>> avoid kernel-doc warnings:
>>
>> Warning: include/asm-generic/bitops/lock.h:19 function parameter 'p'
>> not described in 'arch_test_and_set_bit_lock'
>> Warning: include/asm-generic/bitops/lock.h:41 function parameter 'p'
>> not described in 'arch_clear_bit_unlock'
>> Warning: include/asm-generic/bitops/lock.h:59 function parameter 'p'
>> not described in 'arch___clear_bit_unlock'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Hi Randy,
>
> Thanks for the patch!
>
> The arches implementing those functions use 'addr', not 'p'. In
> generic version originally it was 'addr, but then the functions
> were re-implemented in 84c6591103dbe, thus this 'p' appeared.
>
> Maybe just restore this 'addr' instead of fixing comments?

OK, did that:
https://lore.kernel.org/all/20260501045923.2884548-1-rdunlap@xxxxxxxxxxxxx/

--
~Randy