RE: [PATCH v2] drm: renesas: rz-du: mipi-dsi: drop duplicate platform_set_drvdata() call

From: John Madieu

Date: Fri May 01 2026 - 04:21:43 EST


Hi Biju,

Thanks fort he review.

> -----Original Message-----
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Sent: Freitag, 1. Mai 2026 10:18
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>;
> maarten.lankhorst@xxxxxxxxxxxxxxx; mripard@xxxxxxxxxx;
> tzimmermann@xxxxxxx; airlied@xxxxxxxxx; simona@xxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; john.madieu@xxxxxxxxx
> Subject: RE: [PATCH v2] drm: renesas: rz-du: mipi-dsi: drop duplicate
> platform_set_drvdata() call
>
> Hi John,
>
> Thanks for the patch.
>
> > -----Original Message-----
> > From: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> > Sent: 01 May 2026 09:08
> > Subject: [PATCH v2] drm: renesas: rz-du: mipi-dsi: drop duplicate
> > platform_set_drvdata() call
> >
> > rzg2l_mipi_dsi_probe() calls platform_set_drvdata() twice with the
> > same
> > arguments: once right after devm_drm_bridge_alloc() succeeds and again
> > after the reset controllers have been acquired. The second call is
> redundant; remove it.
>
> May be "Drop the first call and keep the second one, as it is close to
> where the platform data would really be used."
>

Will update the message and send v3?

Regards,
John

> With that fixed,
>
> Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Cheers,
> Biju
>