Re: [PATCH] fs: Fix return in jfs_mkdir and orangefs_mkdir

[Jori Koolstra]

> Op 01-05-2026 09:10 CEST schreef Hongling Zeng <zenghongling@xxxxxxxxxx>:
> 
>  
> Return NULL instead of passing to ERR_PTR while err is zero
> Fixes these smatch warnings:
>   - fs/jfs/namei.c:311 jfs_mkdir() warn: passing zero to 'ERR_PTR'
>   - fs/orangefs/namei.c:369 orangefs_mkdir() warn: passing zero
>     to 'ERR_PTR'
> 
> Fixes: 88d5baf69082 ("Change inode_operations.mkdir to return struct dentry *")
> Signed-off-by: Hongling Zeng <zenghongling@xxxxxxxxxx>
> ---
>  fs/jfs/namei.c      | 2 +-
>  fs/orangefs/namei.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c
> index 60c4a0e0fca5..442d62679262 100644
> --- a/fs/jfs/namei.c
> +++ b/fs/jfs/namei.c
> @@ -309,7 +309,7 @@ static struct dentry *jfs_mkdir(struct mnt_idmap *idmap, struct inode *dip,
>        out1:
>  
>  	jfs_info("jfs_mkdir: rc:%d", rc);
> -	return ERR_PTR(rc);
> +	return rc ? ERR_PTR(rc) : NULL;
>  }
>  
>  /*
> diff --git a/fs/orangefs/namei.c b/fs/orangefs/namei.c
> index bec5475de094..75e65e72c2d6 100644
> --- a/fs/orangefs/namei.c
> +++ b/fs/orangefs/namei.c
> @@ -362,7 +362,7 @@ static struct dentry *orangefs_mkdir(struct mnt_idmap *idmap, struct inode *dir,
>  	__orangefs_setattr(dir, &iattr);
>  out:
>  	op_release(new_op);
> -	return ERR_PTR(ret);
> +	return ret ? ERR_PTR(ret) : NULL;
>  }
>  
>  static int orangefs_rename(struct mnt_idmap *idmap,
> -- 
> 2.25.1

Sure. Feel free to add:

Reviewed-by: Jori Koolstra <jkoolstra@xxxxxxxxx>

However, I will say jfs is kinda low priority, so maybe David will not pick it up.