Re: [PATCH v3 3/5] rust: io: use the `bitfield!` macro in `register!`

From: Yury Norov

Date: Fri May 01 2026 - 13:51:43 EST


On Fri, May 01, 2026 at 01:47:47PM -0400, Yury Norov wrote:
> On Fri, May 01, 2026 at 03:03:20PM +0900, Alexandre Courbot wrote:
> > Replace the local bitfield rules by the equivalent invocation of the
> > `bitfield!` macro.
> >
> > No functional change should be introduced as the `bitfield!` macro has
> > been extracted from the rules of `register!`.
> >
> > Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
>
> Acked-by: Yury Norov <yury.norov@xxxxxxxxx>
>
> If it comes to another round, maybe split switching to a bitfields and
> getting rid of the bitfield_core? For maintainability reasons.

Moreover, you do the same for the other piece of bitfields in #4 and 5.