Re: [PATCH net-next 04/12] net: stmmac: dma: create a separate dma_device pointer
From: Alex Elder
Date: Fri May 01 2026 - 14:08:08 EST
On 5/1/26 12:13 PM, Andrew Lunn wrote:
if (priv->dma_cap.host_dma_width) {
- ret = dma_set_mask_and_coherent(device,
- DMA_BIT_MASK(priv->dma_cap.host_dma_width));
+ u64 mask = DMA_BIT_MASK(priv->dma_cap.host_dma_width);
+
+ ret = dma_set_mask_and_coherent(priv->dma_device, mask);
I'm nitpicking, but i don't think you need to introduce mask.
DMA_BIT_MASK... is already on a line of its own, and is within the 80
limit. Nothing changes here with s/device/priv->dma_device/
Andrew
I did this. It was simply to silence a checkpatch.pl warning
about a long line.
I don't care either way, I'll gladly put it back the way it was.
-Alex