Re: [PATCH v5 1/2] scripts: generate_rust_analyzer.py: add versioning infrastructure

From: Jesung Yang

Date: Sat May 02 2026 - 02:26:22 EST


On Sat, May 2, 2026 at 12:39 AM Tamir Duberstein <tamird@xxxxxxxxxx> wrote:
>
> Here's what I see locally:
>
> % bash check.sh 1.85.0
> + RUST_VERSION=1.85.0
> + LOOKAHEAD=50
> ++ git -C ./rust log -n 50 --format=%s 1.85.0 -- src/tools/rust-analyzer
> ++ grep 'Merge pull request #'
> + subject_string=
> % echo $?
> 1
>
> So it seems to never get past `git log` in the rust repo. When I run
> that git log manually I see nothing containing "Merge pull request
> ...":
>
> % git -C ./rust log -n 50 --format=%s 1.85.0 -- src/tools/rust-analyzer
> Disable some incorrect rust-analyzer diagnostics on beta
> Backport rust-lang/rust-analyzer#18760: internal: Workaround salsa
> cycles leaking
> Bump rustc crates
> Preparing for merge from rust-lang/rust
[...]
>
> What's also interesting is that when I use `--merges` I get no commits at all:
>
> % git -C ./rust log -n1 --merges --format=%s 1.85.0 -- src/tools/rust-analyzer
> %
>
> Something strange is happening; my git is not behaving the same as your git.

I tested the procedure on a fresh Ubuntu 24.04 container using git
2.43.0, and it works as expected: merge commits are not lost, and the
script provides the matching release page link. What does your git
configuration look like? Perhaps some local settings are preventing
merge commits from being displayed?

Best regards,
Jesung