Re: [PATCH] EDAC/sysfs: Fix error handling in edac_device_create_instance()

From: Guangshuo Li

Date: Sat May 02 2026 - 03:21:03 EST


Hi Qiuxu,

Thanks for your review and suggestion.

On Thu, 30 Apr 2026 at 22:59, Zhuo, Qiuxu <qiuxu.zhuo@xxxxxxxxx> wrote:
>
> You may run:
>
> grep -rn "kobject_init_and_add" drivers/edac/
>
> and see there are several other places that need the same fix, like [1], [2] etc.
>
> Could you please address all of them in your previous patch [3] instead of fixing only part of them?
>
> [1] https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/edac/edac_device_sysfs.c#n519
> [2] https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/edac/edac_pci_sysfs.c#n175
> ...
> [3] https://lore.kernel.org/all/20260428160828.377129-1-lgs201920130244@xxxxxxxxx/
>
> Thanks!
> -Qiuxu

I will check all kobject_init_and_add() error paths under
drivers/edac/ and address the similar issues together in a v2 patch.

Thanks,
Guangshuo