Re: [PATCH] staging: atomisp: isp: xnr 3.0 fix whitespace issue

[Andy Shevchenko]

On Sat, May 02, 2026 at 08:25:16AM +0000, Shirin Kaul wrote:
> Fix spaces by replacing them with tabs in function calls to comply
> with kernel coding style.

...

>  static const s16 a[XNR3_LOOK_UP_TABLE_POINTS] = {
>  	-7213, -5580, -4371, -3421, -2722, -2159, -6950, -5585,
> -	    -4529, -3697, -3010, -2485, -2070, -1727, -1428, 0
> -    };
> +	-4529, -3697, -3010, -2485, -2070, -1727, -1428, 0

Leave trailing comma, as it's not a sign that this array has a terminator.

> +	};

Wrong indentation.

...

>  void
>  ia_css_xnr3_encode(
> -    struct sh_css_isp_xnr3_params *to,
> -    const struct ia_css_xnr3_config *from,
> -    unsigned int size)
> +	struct sh_css_isp_xnr3_params *to,
> +	const struct ia_css_xnr3_config *from,
> +	unsigned int size)

It's half-baked solution. Moreover there were handful of patches (better than
this one) to address the same, please, study preexisting work (linux-media
mailing list archives is for your help).

-- 
With Best Regards,
Andy Shevchenko